commit | e3394aa0cff8ad4f1e10710fa5c1e9bc2326268f | [log] [tgz] |
---|---|---|
author | madhusudancs <madhusudancs@123451ca-8445-de46-9d55-352943316053> | Sat Nov 24 02:18:36 2012 +0000 |
committer | madhusudancs <madhusudancs@123451ca-8445-de46-9d55-352943316053> | Sat Nov 24 02:18:36 2012 +0000 |
tree | 6a0c5b676653223b325733adbe71b4da650d68b3 | |
parent | c34a38516e8782c915eee6aadf15dff79eba6946 [diff] |
Add an additional TODO comment for the global dataset directory information. git-svn-id: https://hyracks.googlecode.com/svn/branches/fullstack_hyracks_result_distribution@2482 123451ca-8445-de46-9d55-352943316053
diff --git a/hyracks/hyracks-control/hyracks-control-cc/src/main/java/edu/uci/ics/hyracks/control/cc/dataset/DatasetDirectoryService.java b/hyracks/hyracks-control/hyracks-control-cc/src/main/java/edu/uci/ics/hyracks/control/cc/dataset/DatasetDirectoryService.java index ba9dfab..8aab024 100644 --- a/hyracks/hyracks-control/hyracks-control-cc/src/main/java/edu/uci/ics/hyracks/control/cc/dataset/DatasetDirectoryService.java +++ b/hyracks/hyracks-control/hyracks-control-cc/src/main/java/edu/uci/ics/hyracks/control/cc/dataset/DatasetDirectoryService.java
@@ -23,6 +23,12 @@ import edu.uci.ics.hyracks.api.exceptions.HyracksDataException; import edu.uci.ics.hyracks.api.job.JobId; +/** + * TODO: The potential perils of this global dataset directory service implementation is that, the jobs location information + * is never evicted from the memory and the memory useage grows as the number of jobs in the system grows. What we should + * possibly do is, add an API call for the client to say that it received everything it has to for the job (after it receives + * all the results) completely. Then we can just get rid of the location information for that job. + */ public class DatasetDirectoryService implements IDatasetDirectoryService { private final Map<JobId, NetworkAddress[]> jobPartitionLocationsMap;