| commit | ceb62bead43c6c9879c1a99ed44374da4348fcc4 | [log] [tgz] |
|---|---|---|
| author | Murtadha Hubail <murtadha.hubail@couchbase.com> | Sat Apr 12 21:14:33 2025 +0300 |
| committer | Murtadha Hubail <mhubail@apache.org> | Sun Apr 13 08:48:40 2025 +0000 |
| tree | a20a16be69bff30f175de5f0d4d9176074b7f157 | |
| parent | 044ff43684cdfa3cd6314a44be7b1b3305d223d8 [diff] |
[NO ISSUE][RT] Do not retry IllegalArgumentException on ExponentialRetryPolicy - user model changes: no - storage format changes: no - interface changes: no Details: - When the failure is caused by IllegalArgumentException, do not attempt to retry on ExponentialRetryPolicy since the operation will just fail again with the same exception. Ext-ref: MB-66258 Change-Id: I0d5bb61eff7d85cc924b05b56ca9bc51d469edf2 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19643 Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com> Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
diff --git a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/FlushColumnMetadata.java b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/FlushColumnMetadata.java index 9c58247..f987abe 100644 --- a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/FlushColumnMetadata.java +++ b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/FlushColumnMetadata.java
@@ -563,7 +563,7 @@ addColumn(columnIndex, writer); return new PrimitiveSchemaNode(columnIndex, normalizedTypeTag, primaryKey); default: - throw new IllegalStateException("Unsupported type " + childTypeTag); + throw new IllegalArgumentException("Unsupported type " + childTypeTag); } }
diff --git a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ExponentialRetryPolicy.java b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ExponentialRetryPolicy.java index 72a3bb0..8967e3e 100644 --- a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ExponentialRetryPolicy.java +++ b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ExponentialRetryPolicy.java
@@ -85,6 +85,9 @@ @Override public boolean retry(Throwable failure) throws InterruptedException { + if (failure instanceof IllegalArgumentException) { + return false; + } if (attempt < maxRetries) { long sleepTime = ThreadLocalRandom.current().nextLong(1 + delay); if (printDebugLines) {