commit 97f4eaa45061cc45a37d8e1f60afd4f9306a2856
author Abdullah Alamoudi <bamousaa@gmail.com> Sun Oct 30 10:10:43 2016 -0700
committer abdullah alamoudi <bamousaa@gmail.com> Mon Oct 31 09:10:45 2016 -0700
tree 5e7d9ff6929800b2ece856bc7094fcd5d3dff0ea
parent 9fbff0185951cbe139be733fdee3fdc11d317137

Move Shutdown Hook to NCDriver

Change-Id: Iaef38818e195453eba120a46b5fa7d38b166fd70
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1326
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCDriver.java

diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCDriver.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCDriver.java
index cbd8edd..2323d71 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCDriver.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCDriver.java
@@ -39,12 +39,13 @@
                 System.exit(1);
             }
             ncConfig.loadConfigAndApplyDefaults();
-            final NodeControllerService nService = new NodeControllerService(ncConfig);
+            final NodeControllerService ncService = new NodeControllerService(ncConfig);
             if (LOGGER.isLoggable(Level.SEVERE)) {
-                LOGGER.severe("Setting uncaught exception handler " + nService.getLifeCycleComponentManager());
+                LOGGER.severe("Setting uncaught exception handler " + ncService.getLifeCycleComponentManager());
             }
-            Thread.currentThread().setUncaughtExceptionHandler(nService.getLifeCycleComponentManager());
-            nService.start();
+            Thread.currentThread().setUncaughtExceptionHandler(ncService.getLifeCycleComponentManager());
+            ncService.start();
+            Runtime.getRuntime().addShutdownHook(new NCShutdownHook(ncService));
             while (true) {
                 Thread.sleep(10000);
             }

hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java

diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
index 39a2554..21bf9c2 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
@@ -324,9 +324,6 @@
         if (ncAppEntryPoint != null) {
             ncAppEntryPoint.notifyStartupComplete();
         }
-
-        //add JVM shutdown hook
-        Runtime.getRuntime().addShutdownHook(new NCShutdownHook(this));
     }
 
     private void startApplication() throws Exception {