commit 8f4d70f71204e79d4521df93853d328786e71cd8
author Murtadha Hubail <mhubail@apache.org> Mon Mar 08 19:29:00 2021 +0300
committer Murtadha Hubail <mhubail@apache.org> Tue Mar 09 16:12:36 2021 +0000
tree 78e70feeb75b9739674bb1cbeb8ac51e29dbd689
parent eb3cf8a11f9f8a927b9de085be575098a2697c15

[NO ISSUE][REP] Catch all exception leading to a replica failure

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

- Catch all exceptions and not only IO exceptions to avoid
  uncaught exceptions leading to a node shutdown.

Change-Id: Ibe2286caca247f0070ae399f71a400cd223417b3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10423
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <tillw@apache.org>

asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java

diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java
index be372df..6a23ae6 100644
--- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java
+++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java
@@ -211,7 +211,7 @@
         }
     }
 
-    private synchronized void handleFailure(ISocketChannel replicaSocket, IOException e) {
+    private synchronized void handleFailure(ISocketChannel replicaSocket, Exception e) {
         if (failedSockets.contains(replicaSocket)) {
             return;
         }
@@ -249,7 +249,7 @@
                 }
             } catch (AsynchronousCloseException e) {
                 LOGGER.debug(() -> "Stopped listening on socket:" + dest, e);
-            } catch (IOException e) {
+            } catch (Exception e) {
                 handleFailure(replicaSocket, e);
             }
         }