[NO ISSUE][NET] Do Not Flush Partial Frames on Network Errors

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Do not flush partially read frames when a network error
  is reported to avoid processing invalid partial frames
  before the network failure is detected by the channel
  reader.

Change-Id: Ia35b58412cc293426c18a7cd66d8d0a5962db4e2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3503
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mhubail@apache.org>
Reviewed-by: Till Westmann <tillw@apache.org>
diff --git a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java
index f7ef2aa..75d442f 100644
--- a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java
+++ b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/ChannelControlBlock.java
@@ -124,7 +124,6 @@
     }
 
     void reportRemoteError(int ecode) {
-        ri.flush();
         ri.getFullBufferAcceptor().error(ecode);
         remoteClose.set(true);
     }