[ASTERIXDB-2166] Fix bulk load bloom filters for buddy btree
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Fix bulk loading bloom filters for buddy btrees. For these
bloom filters, the deleted keys are added through the delete method,
which shouldn't be ignored by the bloom filter bulk loader
Change-Id: Icc7ca46c69c9102010f4b407ca0e9d96ba19289b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2152
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>
diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java
index 0dcf349..29ca388 100644
--- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java
+++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java
@@ -26,12 +26,12 @@
private final IIndexBulkLoader bulkLoader;
+ private boolean endedBloomFilterLoad = false;
+
public BloomFilterBulkLoader(IIndexBulkLoader bulkLoader) {
this.bulkLoader = bulkLoader;
}
- private boolean endedBloomFilterLoad = false;
-
@Override
public ITupleReference add(ITupleReference tuple) throws HyracksDataException {
bulkLoader.add(tuple);
@@ -40,7 +40,8 @@
@Override
public ITupleReference delete(ITupleReference tuple) throws HyracksDataException {
- //Noop
+ // this ensure deleted keys are also added to the bulkloader
+ bulkLoader.add(tuple);
return tuple;
}