| commit | 88b10860798c13e2a362a0394cf126c06eaed7f0 | [log] [tgz] |
|---|---|---|
| author | Savyasach Reddy <savyasach.enukonda@couchbase.com> | Tue Jan 21 13:09:59 2025 +0530 |
| committer | Murtadha Hubail <mhubail@apache.org> | Tue Jan 21 13:04:12 2025 +0000 |
| tree | 95e04da5d2a7d3fadb73deba9287b4df4099e6d0 | |
| parent | 30e4262cd532447f5090ef96976f28da909e5dda [diff] |
[NO ISSUE]: Fix failing CloudStorageGCSTest - user model changes: no - storage format changes: no - interface changes: no details: - cc-cloud-storage-gcs.conf has been misconfigured to use 5 bytes instead of 5MB - Avoid unncessary cast to int Change-Id: Ideb99ab281964cd7380695b8554bb0b4d61af51f Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19346 Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Reviewed-by: Murtadha Hubail <mhubail@apache.org>
diff --git a/asterixdb/asterix-app/src/test/resources/cc-cloud-storage-gcs.conf b/asterixdb/asterix-app/src/test/resources/cc-cloud-storage-gcs.conf index 3251439..9b6f547 100644 --- a/asterixdb/asterix-app/src/test/resources/cc-cloud-storage-gcs.conf +++ b/asterixdb/asterix-app/src/test/resources/cc-cloud-storage-gcs.conf
@@ -73,4 +73,3 @@ cloud.storage.cache.policy=selective cloud.max.write.requests.per.second=1000 cloud.max.read.requests.per.second=5000 -cloud.write.buffer.size=5
diff --git a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSWriter.java b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSWriter.java index a95a9d9..89d8fd5 100644 --- a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSWriter.java +++ b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSWriter.java
@@ -66,8 +66,8 @@ guardian.checkIsolatedWriteAccess(bucket, path); // The GCS library triggers a new upload when its internal buffer is full, not on each call to writer.write(). // uploadsToBeTriggered estimates upload count, and we acquire matching tokens from the limiter. - int uploadsToBeTriggered = - (int) ((writtenBytes + page.remaining()) / writeBufferSize) - (int) (writtenBytes / writeBufferSize); + long uploadsToBeTriggered = + ((writtenBytes + page.remaining()) / writeBufferSize) - (writtenBytes / writeBufferSize); while (uploadsToBeTriggered-- > 0) { profiler.objectMultipartUpload(); }