commit 7c62452039c684d6d38afcad8854653024cb41de
author Dmitry Lychagin <dmitry.lychagin@couchbase.com> Fri Dec 04 18:01:45 2020 -0800
committer Dmitry Lychagin <dmitry.lychagin@couchbase.com> Mon Dec 07 18:36:50 2020 +0000
tree 34c87b2a2986676cd13a2bf177619d95a983f44b
parent 4d23f02658e1e5e4ef9d9a7d4e16db590a3b0952

[NO ISSUE][COMP] Handle parsing failures for index related hints

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Recover from parameter parsing failure for index-related hints.
  Log a warning, do not fail the whole query
- Add testcases

Change-Id: If5c1dc78ddd9c4b08628b94b5703c5ca359c0702
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9165
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml

diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index f6113c4..ed5399d 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -5880,9 +5880,10 @@
         <output-dir compare="Text">btree-secondary-self-equi-join_01</output-dir>
       </compilation-unit>
     </test-case>
-    <test-case FilePath="index-join">
+    <test-case FilePath="index-join" check-warnings="true">
       <compilation-unit name="hints-indexnl-params">
         <output-dir compare="Text">hints-indexnl-params</output-dir>
+        <expected-warn><![CDATA[ASX1132: Invalid specification for hint indexnl. ASX1001: Syntax error: In line 1 >>(8, idx_tenk2_1k_2k)<< Encountered <INTEGER_LITERAL> "8" at column 2.  (in line 35, at column 21)]]></expected-warn>
       </compilation-unit>
     </test-case>
     <test-case FilePath="index-join">
@@ -6157,14 +6158,17 @@
         <output-dir compare="Text">dataset-with-meta</output-dir>
       </compilation-unit>
     </test-case>
-    <test-case FilePath="index-selection">
+    <test-case FilePath="index-selection" check-warnings="true">
       <compilation-unit name="hints-skip-index">
         <output-dir compare="Text">hints-skip-index</output-dir>
+        <expected-warn><![CDATA[ASX1132: Invalid specification for hint skip-index. ASX1001: Syntax error: In line 1 >>(13, idx_1k)<< Encountered <INTEGER_LITERAL> "13" at column 2.  (in line 32, at column 19)]]></expected-warn>
       </compilation-unit>
     </test-case>
-    <test-case FilePath="index-selection">
+    <test-case FilePath="index-selection" check-warnings="true">
       <compilation-unit name="hints-use-index">
         <output-dir compare="Text">hints-use-index</output-dir>
+        <expected-warn><![CDATA[ASX1132: Invalid specification for hint use-index. ASX1001: Syntax error: In line 1 >>(18, idx_1k_2k)<< Encountered <INTEGER_LITERAL> "18" at column 2.  (in line 33, at column 15)]]></expected-warn>
+        <expected-warn><![CDATA[ASX1132: Invalid specification for hint use-index. ASX1001: Syntax error: In line 1 >>()<< Encountered ")" at column 2.  (in line 33, at column 15)]]></expected-warn>
       </compilation-unit>
     </test-case>
     <test-case FilePath="index-selection">