[NO ISSUE][RT] no latching on an inverted list during merge
- user-model changes: no
- storage format changes: no
- interface changes: no
Details:
- Do not conduct a latching on an inverted list during
a disk component merge of an inverted index since
a disk component is immutable.
Change-Id: I266135596bbd5158d5fcf5ce3d1735d407be6f0f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2444
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>
diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java
index ca0f40b..b033b99 100644
--- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java
+++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java
@@ -30,7 +30,7 @@
import org.apache.hyracks.storage.common.file.BufferedFileHandle;
/**
- * A simple scan cursor that only reads a frame by frame from the inverted list. This cursor does not
+ * A simple scan cursor that only reads a frame by frame from the inverted list on disk. This cursor does not
* conduct a binary search. It only supports the scan operation. The main purpose of this cursor is
* doing a full-scan of an inverted list during a storage-component-merge process.
*/
@@ -111,14 +111,12 @@
}
currentPageId++;
page = bufferCache.pin(BufferedFileHandle.getDiskPageId(fileId, currentPageId), false);
- page.acquireReadLatch();
pinned = true;
}
@Override
public void unloadPages() throws HyracksDataException {
if (pinned) {
- page.releaseReadLatch();
bufferCache.unpin(page);
pinned = false;
}