addressed Sattam's review comments
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.1.ddl.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.1.ddl.aql
index 8a82439..c04af59 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.1.ddl.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.1.ddl.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using year-month-duration as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
drop dataverse test if exists;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.2.update.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.2.update.aql
index 78a59a2..d07ed34 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.2.update.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.2.update.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using year-month-duration as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
use dataverse test;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.3.query.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.3.query.aql
index b8a7827..a25bfb8 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.3.query.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_0/issue_363_temporal_key_0.3.query.aql
@@ -1,10 +1,13 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using year-month-duration as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
-for $x in dataset('Metadata.Dataset')
-where $x.DataverseName='test'
+use dataverse test;
+
+for $x in dataset('Employee')
+where $x.id > year-month-duration("P350M")
return $x
+
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.1.ddl.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.1.ddl.aql
index 52c3053..1f59a51 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.1.ddl.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.1.ddl.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using datetime as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
drop dataverse test if exists;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.2.update.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.2.update.aql
index ea77da4..0640b52 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.2.update.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.2.update.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using datetime as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
use dataverse test;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.3.query.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.3.query.aql
index b8a7827..2b82717 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.3.query.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_1/issue_363_temporal_key_1.3.query.aql
@@ -1,10 +1,12 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using datetime as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
-for $x in dataset('Metadata.Dataset')
-where $x.DataverseName='test'
-return $x
+use dataverse test;
+
+for $x in dataset('Employee')
+where $x.id > datetime("2007-07-07T07:07:07.777Z")
+return $x
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.1.ddl.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.1.ddl.aql
index 54884c9..97c62cf 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.1.ddl.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.1.ddl.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using time as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
drop dataverse test if exists;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.2.update.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.2.update.aql
index da83cca..f98a754 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.2.update.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.2.update.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using time as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
use dataverse test;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.3.query.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.3.query.aql
index b8a7827..197b461 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.3.query.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_2/issue_363_temporal_key_2.3.query.aql
@@ -1,10 +1,12 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using time as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
-for $x in dataset('Metadata.Dataset')
-where $x.DataverseName='test'
+use dataverse test;
+
+for $x in dataset('Employee')
+where $x.id > time("07:07:07.777Z")
return $x
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.1.ddl.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.1.ddl.aql
index cc13649..5e4ae49 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.1.ddl.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.1.ddl.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using date as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
drop dataverse test if exists;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.2.update.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.2.update.aql
index cf4fb63..624cdc8 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.2.update.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.2.update.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using date as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
use dataverse test;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.3.query.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.3.query.aql
index b8a7827..3f9960e 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.3.query.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_3/issue_363_temporal_key_3.3.query.aql
@@ -1,10 +1,12 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using date as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
-for $x in dataset('Metadata.Dataset')
-where $x.DataverseName='test'
+use dataverse test;
+
+for $x in dataset('Employee')
+where $x.id > date("2007-07-07")
return $x
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.1.ddl.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.1.ddl.aql
index 3b82849..9a3da89 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.1.ddl.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.1.ddl.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using day-time-duration as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
drop dataverse test if exists;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.2.update.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.2.update.aql
index b3809e5..04a35de 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.2.update.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.2.update.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using day-time-duration as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
use dataverse test;
diff --git a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.3.query.aql b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.3.query.aql
index 1475690..e45250b 100644
--- a/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.3.query.aql
+++ b/asterix-app/src/test/resources/metadata/queries/basic/issue_363_temporal_key_4/issue_363_temporal_key_4.3.query.aql
@@ -1,8 +1,8 @@
/*
- * Description : create a dataset providing hints but use whitespace
+ * Description : create a dataset using day-time-duration as the primary key
* Expected Res : Success
- * Date : 29 Jan 2013
- * Issue : 251
+ * Date : 7 May 2013
+ * Issue : 363
*/
use dataverse test;
diff --git a/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_0/issue363_temporal_key_0.1.adm b/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_0/issue363_temporal_key_0.1.adm
index bed9a9b..064b5bb 100644
--- a/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_0/issue363_temporal_key_0.1.adm
+++ b/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_0/issue363_temporal_key_0.1.adm
@@ -1 +1 @@
-{ "DataverseName": "test", "DatasetName": "Employee", "DataTypeName": "Emp", "DatasetType": "INTERNAL", "InternalDetails": { "FileStructure": "BTREE", "PartitioningStrategy": "HASH", "PartitioningKey": [ "id" ], "PrimaryKey": [ "id" ], "GroupName": "DEFAULT_NG_ALL_NODES" }, "ExternalDetails": null, "FeedDetails": null, "Hints": {{ }}, "Timestamp": "Wed May 01 21:31:36 PDT 2013", "DatasetId": 109, "PendingOp": 0 }
\ No newline at end of file
+{ "id":year-month-duration("P2013Y"), "name": "Bob" }
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_1/issue363_temporal_key_1.1.adm b/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_1/issue363_temporal_key_1.1.adm
index bed9a9b..6667a59 100644
--- a/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_1/issue363_temporal_key_1.1.adm
+++ b/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_1/issue363_temporal_key_1.1.adm
@@ -1 +1 @@
-{ "DataverseName": "test", "DatasetName": "Employee", "DataTypeName": "Emp", "DatasetType": "INTERNAL", "InternalDetails": { "FileStructure": "BTREE", "PartitioningStrategy": "HASH", "PartitioningKey": [ "id" ], "PrimaryKey": [ "id" ], "GroupName": "DEFAULT_NG_ALL_NODES" }, "ExternalDetails": null, "FeedDetails": null, "Hints": {{ }}, "Timestamp": "Wed May 01 21:31:36 PDT 2013", "DatasetId": 109, "PendingOp": 0 }
\ No newline at end of file
+{ "id":datetime("2013-01-01T00:00:00"), "name": "Bob" }
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_2/issue363_temporal_key_2.1.adm b/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_2/issue363_temporal_key_2.1.adm
index bed9a9b..b0ecf7c 100644
--- a/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_2/issue363_temporal_key_2.1.adm
+++ b/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_2/issue363_temporal_key_2.1.adm
@@ -1 +1,2 @@
-{ "DataverseName": "test", "DatasetName": "Employee", "DataTypeName": "Emp", "DatasetType": "INTERNAL", "InternalDetails": { "FileStructure": "BTREE", "PartitioningStrategy": "HASH", "PartitioningKey": [ "id" ], "PrimaryKey": [ "id" ], "GroupName": "DEFAULT_NG_ALL_NODES" }, "ExternalDetails": null, "FeedDetails": null, "Hints": {{ }}, "Timestamp": "Wed May 01 21:31:36 PDT 2013", "DatasetId": 109, "PendingOp": 0 }
\ No newline at end of file
+{ "id":time("20:37:19+08:00"), "name": "Alex" }
+{ "id":time("21:39:17.948-04:00"), "name": "Bob" }
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_3/issue363_temporal_key_3.1.adm b/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_3/issue363_temporal_key_3.1.adm
index bed9a9b..6f45af2 100644
--- a/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_3/issue363_temporal_key_3.1.adm
+++ b/asterix-app/src/test/resources/metadata/results/basic/issue_363_temporal_key_3/issue363_temporal_key_3.1.adm
@@ -1 +1 @@
-{ "DataverseName": "test", "DatasetName": "Employee", "DataTypeName": "Emp", "DatasetType": "INTERNAL", "InternalDetails": { "FileStructure": "BTREE", "PartitioningStrategy": "HASH", "PartitioningKey": [ "id" ], "PrimaryKey": [ "id" ], "GroupName": "DEFAULT_NG_ALL_NODES" }, "ExternalDetails": null, "FeedDetails": null, "Hints": {{ }}, "Timestamp": "Wed May 01 21:31:36 PDT 2013", "DatasetId": 109, "PendingOp": 0 }
\ No newline at end of file
+{ "id":date("2010-01-01"), "name": "John" }
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.1.ddl.aql b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.1.ddl.aql
index 754ea81..84fe314 100644
--- a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.1.ddl.aql
+++ b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.1.ddl.aql
@@ -1,3 +1,9 @@
+/*
+ * Description : test duration constructors
+ * Expected Res : Success
+ * Date : 7 May 2013
+ */
+
drop dataverse test if exists;
create dataverse test;
diff --git a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.2.update.aql b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.2.update.aql
index e69de29..0c32771 100644
--- a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.2.update.aql
+++ b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.2.update.aql
@@ -0,0 +1,5 @@
+/*
+ * Description : test duration constructors
+ * Expected Res : Success
+ * Date : 7 May 2013
+ */
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.3.query.aql b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.3.query.aql
index 6db5228..898ab18 100644
--- a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.3.query.aql
+++ b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_01/duration_01.3.query.aql
@@ -1,3 +1,9 @@
+/*
+ * Description : test duration constructors
+ * Expected Res : Success
+ * Date : 7 May 2013
+ */
+
use dataverse test;
let $c1 := duration("P30Y10M25DT13H12M50S")
diff --git a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.1.ddl.aql b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.1.ddl.aql
index 754ea81..f3978bf 100644
--- a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.1.ddl.aql
+++ b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.1.ddl.aql
@@ -1,3 +1,10 @@
+/*
+ * Description : test sub type duration (year-month-duration and day-time-duration) constructors
+ * Expected Res : Success
+ * Date : 7 May 2013
+ * issue : 363
+ */
+
drop dataverse test if exists;
create dataverse test;
diff --git a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.2.update.aql b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.2.update.aql
index e69de29..73d2817 100644
--- a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.2.update.aql
+++ b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.2.update.aql
@@ -0,0 +1,6 @@
+/*
+ * Description : test sub type duration (year-month-duration and day-time-duration) constructors
+ * Expected Res : Success
+ * Date : 7 May 2013
+ * issue : 363
+ */
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.3.query.aql b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.3.query.aql
index cedec99..f526bc4 100644
--- a/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.3.query.aql
+++ b/asterix-app/src/test/resources/runtimets/queries/constructor/duration_02/duration_02.3.query.aql
@@ -1,3 +1,10 @@
+/*
+ * Description : test sub type duration (year-month-duration and day-time-duration) constructors
+ * Expected Res : Success
+ * Date : 7 May 2013
+ * issue : 363
+ */
+
use dataverse test;
let $c1 := year-month-duration("P30Y10M")
diff --git a/asterix-om/src/main/java/edu/uci/ics/asterix/om/base/temporal/ADurationParserFactory.java b/asterix-om/src/main/java/edu/uci/ics/asterix/om/base/temporal/ADurationParserFactory.java
index 418c05a..84e2386 100644
--- a/asterix-om/src/main/java/edu/uci/ics/asterix/om/base/temporal/ADurationParserFactory.java
+++ b/asterix-om/src/main/java/edu/uci/ics/asterix/om/base/temporal/ADurationParserFactory.java
@@ -35,6 +35,8 @@
private static final String onlyYearMonthErrorMessage = "Only year-month fields are allowed";
private static final String onlyDayTimeErrorMessage = "Only day-time fields are allowed";
+ private static final int DECIMAL_UNIT = 10;
+
private ADurationParserFactory() {
}
@@ -130,7 +132,7 @@
for (; offset < length; offset++) {
if (charAccessor.getCharAt(offset) >= '0' && charAccessor.getCharAt(offset) <= '9') {
// accumulate the digit fields
- value = value * 10 + charAccessor.getCharAt(offset) - '0';
+ value = value * DECIMAL_UNIT + charAccessor.getCharAt(offset) - '0';
} else {
switch (charAccessor.getCharAt(offset)) {
case 'Y':
@@ -208,7 +210,8 @@
if (charAccessor.getCharAt(offset + i) >= '0'
&& charAccessor.getCharAt(offset + i) <= '9') {
if (i < 4) {
- millisecond = millisecond * 10 + (charAccessor.getCharAt(offset + i) - '0');
+ millisecond = millisecond * DECIMAL_UNIT
+ + (charAccessor.getCharAt(offset + i) - '0');
} else {
throw new HyracksDataException(durationErrorMessage
+ ": wrong MILLISECOND field.");
diff --git a/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/ADayTimeDurationConstructorDescriptor.java b/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/ADayTimeDurationConstructorDescriptor.java
index 0acb47f..0d43c3d 100644
--- a/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/ADayTimeDurationConstructorDescriptor.java
+++ b/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/ADayTimeDurationConstructorDescriptor.java
@@ -64,7 +64,7 @@
private ArrayBackedValueStorage outInput = new ArrayBackedValueStorage();
private ICopyEvaluator eval = args[0].createEvaluator(outInput);
- private String errorMessage = "This can not be an instance of year-month-duration";
+ private String errorMessage = "This can not be an instance of day-time-duration";
private AMutableDayTimeDuration aDayTimeDuration = new AMutableDayTimeDuration(0);
@SuppressWarnings("unchecked")
private ISerializerDeserializer<ADayTimeDuration> dayTimeDurationSerde = AqlSerializerDeserializerProvider.INSTANCE