commit 709ea795627554fde484d1f0ce33cc10aab2e0cb
author Ali Alsuliman <ali.al.solaiman@gmail.com> Tue Apr 16 17:56:12 2019 -0700
committer Ali Alsuliman <ali.al.solaiman@gmail.com> Wed Apr 17 05:24:39 2019 +0000
tree 472c396971df2ac33008fd01f7059f4d6224bd2d
parent 4f87f893b57d617279fda7926328ae5b773777a7

[ASTERIXDB-2516][RT] Prevent passing null type to comparator provider

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
This change is to disallow passing null as IAType to the comparator
provider when asking for a comparator. It also includes few fixes
for issues appearing as a result of this change.

- changed the generic comparator to check whether the tag of data
at runtime is a valid tag and throw an exception if not.
- modified the comparator provider to return non-tagged comparator
for IAType SHORTWITHOUTINFOTYPE which is a short without tag.
SHORTWITHOUTINFOTYPE should not use the generic comparator since
the input data has no tag.
- fixed Dataset class to consider external dataset when getting
the IAType of the primary keys. The primary keys for external
datasets are different from regular datasets. They are not
part of the record type. Previously, null would be returned.
This would cause a failure when getting a comparator for the
primary keys of an external dataset since the type passed is null.
- fixed the TypeTraitProvider to give the correct lengths for
duration, day_time_duration, and year_month_duration.

Change-Id: I37767a3f3d1e3b29597d2a4998c0b60005cadb09
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3336
Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <tillw@apache.org>