commit 68183c9d0111ded02380711e017d93c0f138b530
author Hussain Towaileb <Hussain.Towaileb@Couchbase.com> Thu Jun 13 17:46:56 2019 +0300
committer Hussain Towaileb <hussainht@gmail.com> Thu Jun 13 16:38:53 2019 +0000
tree 154d011f1994ec8f3befa2742b9efc9b9a7cf348
parent f387fe24c21d537bca9913815f33466ec8b2520f

[NO ISSUE][FUN] round() remove unnecessary Math.abs()

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Removed unnecessary Math.abs().

Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3438
Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Hussain Towaileb <hussainht@gmail.com>
Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java

diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
index c06fd35..11aa620 100644
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
@@ -172,7 +172,7 @@
         if (roundingDigit >= 0) {
 
             // Multiplier based on round digit
-            double multiplier = Math.pow(10, Math.abs(roundingDigit));
+            double multiplier = Math.pow(10, roundingDigit);
 
             switch (valueTypeTag) {
                 // For zero and positive digit rounding, no need to do anything for integers
@@ -209,8 +209,8 @@
         }
         // Left of decimal (negative roundingDigit value)
         else {
-            // Multiplier based on round digit
-            double multiplier = Math.pow(10, Math.abs(roundingDigit));
+            // Multiplier based on round digit (convert to positive digit)
+            double multiplier = Math.pow(10, -roundingDigit);
 
             switch (valueTypeTag) {
                 case TINYINT: