commit 64133550f3a6e5d83e3933c2d1fde4eddd907479
author salsubaiee <salsubaiee@gmail.com> Sat Apr 20 21:07:48 2013 -0700
committer salsubaiee <salsubaiee@gmail.com> Sat Apr 20 21:07:48 2013 -0700
tree b2de984fd85f9f419fb2daa5df30f91008e445b0
parent 9f0569d5e8973af214428aeb69b9534576d2d477

Addressed code review comments.

asterix-app/src/main/java/edu/uci/ics/asterix/aql/translator/AqlTranslator.java

diff --git a/asterix-app/src/main/java/edu/uci/ics/asterix/aql/translator/AqlTranslator.java b/asterix-app/src/main/java/edu/uci/ics/asterix/aql/translator/AqlTranslator.java
index cc8c45c..d941289 100644
--- a/asterix-app/src/main/java/edu/uci/ics/asterix/aql/translator/AqlTranslator.java
+++ b/asterix-app/src/main/java/edu/uci/ics/asterix/aql/translator/AqlTranslator.java
@@ -518,8 +518,6 @@
         String dataverseName = null;
         String datasetName = null;
         String indexName = null;
-        Dataset ds = null;
-        Index index = null;
         JobSpecification spec = null;
         try {
             CreateIndexStatement stmtCreateIndex = (CreateIndexStatement) stmt;
@@ -530,7 +528,7 @@
             }
             datasetName = stmtCreateIndex.getDatasetName().getValue();
 
-            ds = MetadataManager.INSTANCE.getDataset(metadataProvider.getMetadataTxnContext(), dataverseName,
+            Dataset ds = MetadataManager.INSTANCE.getDataset(metadataProvider.getMetadataTxnContext(), dataverseName,
                     datasetName);
             if (ds == null) {
                 throw new AlgebricksException("There is no dataset with this name " + datasetName + " in dataverse "
@@ -552,7 +550,7 @@
             }
 
             //#. add a new index with PendingAddOp
-            index = new Index(dataverseName, datasetName, indexName, stmtCreateIndex.getIndexType(),
+            Index index = new Index(dataverseName, datasetName, indexName, stmtCreateIndex.getIndexType(),
                     stmtCreateIndex.getFieldExprs(), stmtCreateIndex.getGramLength(), false,
                     IMetadataEntity.PENDING_ADD_OP);
             MetadataManager.INSTANCE.addIndex(metadataProvider.getMetadataTxnContext(), index);
@@ -602,7 +600,7 @@
                 MetadataManager.INSTANCE.abortTransaction(mdTxnCtx);
             }
 
-            if (ds != null && index != null && spec != null) {
+            if (spec != null) {
                 //#. execute compensation operations
                 //   remove the index in NC
                 mdTxnCtx = MetadataManager.INSTANCE.beginTransaction();