[NO ISSUE][STO] Fix Time Unit Comparison For Periodic Flushes
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- The dataset checkpoint interval is specified in the
configuration using seconds while the dataset last
flush time is tracked in nanos. This change fixes the
comparison by converting the dataset checkpoint
interval to nanos.
Change-Id: Id5a9b86207ea25ba44840af01324041525ac5bd9
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3542
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <tillw@apache.org>
diff --git a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java
index 43758d3..6582670 100644
--- a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java
+++ b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java
@@ -21,6 +21,7 @@
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
+import java.util.concurrent.TimeUnit;
import java.util.function.Predicate;
import org.apache.asterix.common.api.IDatasetLifecycleManager;
@@ -43,13 +44,13 @@
private static final Logger LOGGER = LogManager.getLogger();
private static final long NO_SECURED_LSN = -1L;
- private final long datasetCheckpointInterval;
+ private final long datasetCheckpointIntervalNanos;
private final Map<TxnId, Long> securedLSNs;
private boolean suspended = false;
public CheckpointManager(ITransactionSubsystem txnSubsystem, CheckpointProperties checkpointProperties) {
super(txnSubsystem, checkpointProperties);
- datasetCheckpointInterval = checkpointProperties.getDatasetCheckpointInterval();
+ datasetCheckpointIntervalNanos = TimeUnit.SECONDS.toNanos(checkpointProperties.getDatasetCheckpointInterval());
securedLSNs = new HashMap<>();
}
@@ -134,7 +135,7 @@
return lsmIndex -> {
if (lsmIndex.isPrimaryIndex()) {
PrimaryIndexOperationTracker opTracker = (PrimaryIndexOperationTracker) lsmIndex.getOperationTracker();
- return currentTime - opTracker.getLastFlushTime() >= datasetCheckpointInterval;
+ return currentTime - opTracker.getLastFlushTime() >= datasetCheckpointIntervalNanos;
}
return false;
};