commit 51b0283d9575f670ca00aa359610f54b2a25e93c
author Murtadha Hubail <mhubail@apache.org> Mon Oct 30 15:42:13 2023 +0300
committer Murtadha Hubail <mhubail@apache.org> Mon Oct 30 21:14:13 2023 +0000
tree 1fa264fae626f17c84598e318743a0d535bb9b0f
parent a2f7ab57eec0a8bb8ffa80ea880e1a76cd6da1be

[NO ISSUE][CLUS] no replica failure messages on disabled replication

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

- Do not send replica failure messages to NCs on node failures
  when replication is disabled.

Change-Id: Ided98c584f9ba7ed81683005da86da5eab4da5d1
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17887
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mhubail@apache.org>
Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java

diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
index 4135f35..dde2371 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
@@ -332,6 +332,9 @@
 
     private void notifyFailedReplica(IClusterStateManager clusterManager, String nodeID,
             InetSocketAddress replicaAddress) {
+        if (!replicationEnabled) {
+            return;
+        }
         LOGGER.info("notify replica failure of nodeId {} at {}", nodeID, replicaAddress);
         Set<String> ncs = clusterManager.getParticipantNodes(true);
         ReplicaFailedMessage message =