commit 4c28936903de6a969fc3770a002e078a428bcde1
author Michael Blow <michael.blow@couchbase.com> Mon Jul 07 00:27:36 2025 -0400
committer Michael Blow <mblow@apache.org> Mon Jul 07 05:59:35 2025 +0000
tree 9a64a31334823c199d60a3d540879234586f42cd
parent 84ae52b3818cd83978d8781d24b39bc34d030ba5

[NO ISSUE][HYR][HTTP] Fix omitted access log on some netty responses

The CLFLogger had assumptions that if a DefaultFullHttpResponse was
not received, it would receive one or more DefaultHttpContent
instances followed by a LastHttpContent. In reality, Netty is free to
return a DefaultHttpContent that also implements LastHttpContent,
which causes the CLF log entry to never be emitted.

Ext-ref: MB-67407
Change-Id: I8aa6c6e8e61eb63a83dd259afbe30b08969128eb
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20027
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Michael Blow <mblow@apache.org>
Reviewed-by: Michael Blow <mblow@apache.org>

hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/CLFLogger.java

diff --git a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/CLFLogger.java b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/CLFLogger.java
index a24ed95..6476ab9 100644
--- a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/CLFLogger.java
+++ b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/CLFLogger.java
@@ -34,10 +34,8 @@
 import io.netty.handler.codec.http.DefaultFullHttpResponse;
 import io.netty.handler.codec.http.DefaultHttpContent;
 import io.netty.handler.codec.http.DefaultHttpResponse;
-import io.netty.handler.codec.http.HttpContent;
 import io.netty.handler.codec.http.HttpHeaderNames;
 import io.netty.handler.codec.http.HttpRequest;
-import io.netty.handler.codec.http.HttpResponse;
 import io.netty.handler.codec.http.LastHttpContent;
 
 //Based in part on LoggingHandler from Netty
@@ -99,18 +97,15 @@
 
     @Override
     public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) {
-        if (msg instanceof DefaultHttpResponse) {
-            HttpResponse resp = (DefaultHttpResponse) msg;
+        if (msg instanceof DefaultHttpResponse resp) {
             statusCode = resp.status().code();
             if (msg instanceof DefaultFullHttpResponse) {
-                lastChunk = true;
                 respSize = resp.headers().getInt(HttpHeaderNames.CONTENT_LENGTH, 0);
             }
-        } else if (msg instanceof DefaultHttpContent) {
-            HttpContent content = (DefaultHttpContent) msg;
-
+        } else if (msg instanceof DefaultHttpContent content) {
             respSize += content.content().readableBytes();
-        } else if (msg instanceof LastHttpContent) {
+        }
+        if (msg instanceof LastHttpContent) {
             lastChunk = true;
         }