commit | 4a290fe19b45b803c820c30412831c5033a62abe | [log] [tgz] |
---|---|---|
author | Michael Blow <mblow@apache.org> | Thu Mar 23 13:08:05 2017 -0700 |
committer | Michael Blow <mblow@apache.org> | Thu Mar 23 16:42:46 2017 -0700 |
tree | 283b3c7611467f27053326590e52ccb5de4bf02b | |
parent | 7d554fcb259e128c077a62b57728c069f50871b3 [diff] |
Fix Large Page Budget Check The logic for ensuring for large page budget is off by one; fix the comparison. Avoids silly log messages like the following: Exceeding buffer cache budget of 1674 by 0 pages in order to satisfy large page read Change-Id: I047d52f53ae26febc8e8f0a54de557409276eb91 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1611 Reviewed-by: Yingyi Bu <buyingyi@gmail.com> Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu> BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
diff --git a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java index c12f288..872ac35 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java
@@ -209,7 +209,7 @@ } private void ensureBudgetForLargePages(int delta) { - while (numPages.get() + delta >= maxAllowedNumPages) { + while (numPages.get() + delta > maxAllowedNumPages) { ICachedPageInternal victim = findVictimByEviction(); if (victim != null) { final int victimMultiplier = victim.getFrameSizeMultiplier();