commit 2c04ae0751acb521dedbc61c4cf30d2825d67ec9
author Murtadha Hubail <mhubail@apache.org> Tue Nov 21 15:58:01 2017 +0300
committer Murtadha Hubail <mhubail@apache.org> Tue Nov 21 14:20:03 2017 -0800
tree 073d99f8b96bbfaed2a47c731d0ebd1fcad6b0f4
parent e5a65429d94c34b3079a3fe6bad206089c2c193c

[ASTERIXDB-2171][STO] Remove Temporary Datasets

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Removed all reference to temporary datasets.

Details:
- Remove temporary datasets grammar but reserve
  <TEMPORARY> token.
- Remove special callbacks for temp datasets.
- Remove metadata garbage collector thread.
- Remove isTemp flag from datasets.
- Remove special storage path for temp datasets.
- Remove temp datasets test cases.

Change-Id: Ib50ea27e2ec9c114508cd4a109cf646e2f20dcb0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2172
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Michael Blow <mblow@apache.org>

asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj

diff --git a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
index a58ce0f..7ac8c57 100644
--- a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
+++ b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
@@ -501,7 +501,6 @@
   DatasetDecl dsetDecl = null;
   boolean autogenerated = false;
   String compactionPolicy = null;
-  boolean temp = false;
   Pair<Integer, List<String>> filterField = null;
   Pair<Identifier,Identifier> metaTypeComponents = new Pair<Identifier, Identifier>(null, null);
 }
@@ -533,7 +532,7 @@
                                    ifNotExists);
       }
 
-    | (<INTERNAL> | <TEMPORARY> { temp = true; })?
+    | ( <INTERNAL> )?
     Dataset() nameComponents = QualifiedName()
     <LEFTPAREN> typeComponents = TypeName() <RIGHTPAREN>
     (
@@ -561,8 +560,7 @@
         InternalDetailsDecl idd = new InternalDetailsDecl(primaryKeyFields.second,
                                                           primaryKeyFields.first,
                                                           autogenerated,
-                                                          filterField == null? null : filterField.second,
-                                                          temp);
+                                                          filterField == null? null : filterField.second);
         dsetDecl = new DatasetDecl(nameComponents.first,
                                    nameComponents.second,
                                    typeComponents.first,
@@ -3265,7 +3263,7 @@
   | <SOME : "some">
   | <START : "start">
   | <STOP : "stop">
-  | <TEMPORARY : "temporary">
+  | <TEMPORARY : "temporary"> // intentionally not used but reserved for future usage
   | <THEN : "then">
   | <TYPE : "type">
   | <TO : "to">