| commit | 23e1a700d7fff56e7f289f41cf8c44c472eb3f00 | [log] [tgz] |
|---|---|---|
| author | Kui LIU <brucekuiliu@gmail.com> | Sun Apr 22 11:53:21 2018 +0200 |
| committer | Michael Blow <mblow@apache.org> | Thu May 03 10:43:55 2018 -0700 |
| tree | b85870abf4b1f626e58d6b0149d0ea11a3d26866 | |
| parent | bf48c49f4ea64da9aeea8384570c4d38102adf88 [diff] |
[ASTERIXDB-2370][*DB] Modify the inconsistent method name "isFull" - taken from https://github.com/apache/asterixdb/pull/7 The method is named as "isFull". However, the method does set the boolean variable full. Thus, rename the method as "setFull" should be more intuitive than "isFull" since "isFull" is a query asking whether the object is full or not. Change-Id: I99bf451367171afb3fc0511a6170eb4c492fc69f Reviewed-on: https://asterix-gerrit.ics.uci.edu/2629 Contrib: Michael Blow <mblow@apache.org> Integration-Tests: Michael Blow <mblow@apache.org> Tested-by: Michael Blow <mblow@apache.org> Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu> Reviewed-by: Murtadha Hubail <mhubail@apache.org>
diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java index a94f073..2ed2ac9 100644 --- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java +++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java
@@ -57,7 +57,7 @@ } } - public synchronized void isFull(boolean full) { + public synchronized void setFull(boolean full) { this.full.set(full); this.notify(); }
diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java index 7a9d75f..6c8e372 100644 --- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java +++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java
@@ -167,7 +167,7 @@ private synchronized void appendToLogBuffer(ILogRecord logRecord) throws InterruptedException { if (!currentTxnLogBuffer.hasSpace(logRecord)) { - currentTxnLogBuffer.isFull(true); + currentTxnLogBuffer.setFull(true); if (logRecord.getLogSize() > logPageSize) { getAndInitNewLargePage(logRecord.getLogSize()); } else {