[ASTERIXDB-3560][COMP] Routine was switched to void as return value not needed
Change-Id: Idfd718b4d60f848d9345d85ba3bfd513cd2ea3a5
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19385
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: <murali.krishna@couchbase.com>
Reviewed-by: Vijay Sarathy <vijay.sarathy@couchbase.com>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
index 1dc37c4..0861c01 100644
--- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
+++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
@@ -970,7 +970,7 @@
}
// Each outer join will create one set of dependencies. The right side depends on the left side.
- private boolean buildDependencyList(ILogicalOperator op, JoinOperator jO,
+ private void buildDependencyList(ILogicalOperator op, JoinOperator jO,
List<Quadruple<Integer, Integer, JoinOperator, Integer>> outerJoinsDependencyList, int rightSideBits)
throws AlgebricksException {
AbstractBinaryJoinOperator outerJoinOp = (AbstractBinaryJoinOperator) op;
@@ -1018,7 +1018,6 @@
outerJoinsDependencyList.add(new Quadruple(leftSideExprBits, rightSideBits, jO, 0));
}
}
- return true;
}
private ILogicalExpression joinExprFound(ILogicalOperator op) {
@@ -1073,10 +1072,7 @@
&& (firstLeafInputNumber < lastLeafInputNumber)) { // if more is than one leafInput, only then buildSets make sense.
buildSets.add(new Triple<>(k, lastLeafInputNumber - firstLeafInputNumber + 1, true)); // convert the second to boolean later
}
- boolean ret = buildDependencyList(op, jO, outerJoinsDependencyList, k);
- if (!ret) {
- return false;
- }
+ buildDependencyList(op, jO, outerJoinsDependencyList, k);
}
}
} else {